Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Make tooltips mobile friendly. #1106

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Make tooltips mobile friendly. #1106

merged 10 commits into from
Oct 9, 2024

Conversation

uiuxxx
Copy link
Contributor

@uiuxxx uiuxxx commented Sep 18, 2024 •
edited
Loading

  • Replace important tooltips with popovers to make them interactive on mobiles / touch devices
  • Create a css pattern for the dashed text underlined style and apply it
  • Minor fixes to the Rate provider section
    • Include new dashed underline pattern to the existing tooltip on Rate Providers
    • Replace the 'Rate provider(s)' text with 'Rate provider' when 1 item and 'Rate providers' when more than 1 item.
  • Minor update to target weight section:
    • Display an 'N/A' with tooltip for non-weighted pools
    • Include new tooltip around this to explain why there is no target
    • Fix alignment issues

Visuals for the items in addition to the replacement of tooltips for popovers:

cs 2024-09-18 at 13 34 56@2x

cs 2024-09-18 at 13 35 10@2x

cs 2024-09-18 at 13 35 18@2x

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:56pm
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:56pm

@uiuxxx uiuxxx marked this pull request as ready for review September 19, 2024 17:12
@uiuxxx uiuxxx requested a review from garethfuller September 19, 2024 17:12
garethfuller
garethfuller suggested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@garethfuller garethfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a crazy double scroll bar going on on the pools page.

Screenshot 2024-09-24 at 11 43 21

@uiuxxx
Copy link
Contributor Author

uiuxxx commented Oct 7, 2024

There's a crazy double scroll bar going on on the pools page.

This should now be fixed

@uiuxxx uiuxxx requested a review from garethfuller October 7, 2024 16:58
@garethfuller garethfuller merged commit 860e2d4 into main Oct 9, 2024
7 checks passed
@garethfuller garethfuller deleted the ui/popovers branch October 9, 2024 08:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@garethfuller garethfuller garethfuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uiuxxx @garethfuller